Skip to content

Added name attribute to Device class. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
savfaire merged 1 commit into from
Jun 6, 2023
Merged

Added name attribute to Device class. #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions clearblade/cloud/iot_v1/device_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ class Device():
Data class for Clearblade Device
"""
# TODO: find a better way to construct the Device object. I dont like so much parameter in a constructor
# From google SDK docs: The field ``name`` must be empty. The server generates ``name`` from the device
# registry ``id`` and the ``parent`` field.

def __init__(self, id: str, num_id: str = None,
credentials: list = [], last_heartbeat_time: str = None, last_event_time: str = None,
Expand All @@ -74,6 +76,7 @@ def __init__(self, id: str, num_id: str = None,
log_level: str = LogLevel.NONE, meta_data: dict = {}, gateway_config : dict = {"gatewayType": GatewayType.NON_GATEWAY}) -> None:

self._id = id
self._name = ''
self._num_id = num_id
self._credentials = credentials
self._last_heartbeat_time = last_heartbeat_time
Expand Down Expand Up @@ -140,6 +143,10 @@ def from_json(json):
def id(self):
return self._id

@property
def name(self):
return self._name

@property
def num_id(self):
return self._num_id
Expand Down