feat: make Task execute timeout configurable via connection "task_timeout" (default 10s)#2
Merged
Chance-fyi merged 1 commit intoJun 8, 2026
Conversation
…eout' (default 10s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All SQL Server queries are executed inside a Hyperf Task (to simulate coroutines over the blocking PDO/ODBC driver).
SqlServerTask's methods use a bare#[Task], so the task execute timeout is the Hyperf default of 10 seconds, hardcoded with no way to change it.A query that legitimately runs longer than 10s fails with:
and its result is lost. We hit this in production on a heavy multi-table report query that intermittently crosses 10s.
Change
Make the task execute timeout configurable per connection via a
task_timeoutoption (in seconds), defaulting to10to keep current behaviour.SqlServerConnectionnow dispatches the task throughTaskExecutorwith the configured timeout instead of relying on the static#[Task]annotation.#[Task]attribute onSqlServerTaskis removed accordingly — dispatch is now explicit; execution inside the task worker is unchanged.task_timeoutthe timeout stays 10s, so existing users need no change.Usage