tools: add benchmark reporting utilities - #715
Draft
skku970412 wants to merge 4 commits into
Draft
skku970412 wants to merge 4 commits into
skku970412 wants to merge 4 commits into
Conversation
Collaborator
|
This is an interesting patch. It might do what the Issue is asking for. I have a couple of initial concerns:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Issue #590 asks for benchmark history tracking and PR performance drift visibility. This first pass focuses on durable, machine-readable benchmark artifacts without changing simulator behavior or adding PR comments.
What changed
tools/bench/normalize_catch2_benchmarks.py.tools/bench/compare_benchmark_results.py..github/workflows/benchmark-report.ymlas a manual workflow with read-only permissions and uploaded artifacts.docs/src/Benchmark-reporting.rst.Out of scope
Verification
git diff --checkpython3 -m compileall tools/bench test/pythonpython3 -m unittest discover -v --start-directory test/pythonpassed 270 tests with 1 skipped test./config.shmake -j"$(nproc)" test/bin/000-test-maintest/bin/000-test-main --list-reporterstest/bin/000-test-main --list-testsgrep -R "BENCHMARK" -n test/cpp src inc || trueBenchmarkResults--fail-on-regressionpassed with 9 pass, 0 warn, and 0 failactionlintwas not available locallyFollow-ups