chore: standardize catch.hpp import#700
Merged
ngober merged 1 commit intoChampSim:developfrom Mar 25, 2026
Merged
Conversation
ngober
approved these changes
Mar 25, 2026
Collaborator
ngober
left a comment
ngober
left a comment
There was a problem hiding this comment.
This looks like a good change!
github-actions Bot
added a commit
that referenced
this pull request
Mar 25, 2026
Author: Caleb Norton Committer: GitHub chore: standardize catch.hpp import (#700) catch2 dependency includes should be angle brackets, not double quotes - otherwise you will get errors such as the following only a few test files had quotes, most already have angle brackets ```bash champsim> g++ @global.options @absolute.options -MM -MT .csconfig/test/602-walk-latency.d -MT .csconfig/test/602-walk-latency.o -I.csconfig -MF .csconfig/test/602-walk-latency.d test/cpp/src/602-walk-latency.cc champsim> test/cpp/src/602-walk-latency.cc:1:10: fatal error: catch.hpp: No such file or directory champsim> 1 | #include "catch.hpp" champsim> ``` ran clang format to sort the imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
catch2 dependency includes should be angle brackets, not double quotes - otherwise you will get errors such as the following
only a few test files had quotes, most already have angle brackets
ran clang format to sort the imports