make dib_inorder_width and dib_hit_buffer_size configurable#696
make dib_inorder_width and dib_hit_buffer_size configurable#696ngober merged 1 commit intoChampSim:developfrom
Conversation
| 'window_size': ' .dib_window({DIB[window_size]})', | ||
| 'inorder_width': ' .dib_inorder_width(champsim::bandwidth::maximum_type{{{DIB[inorder_width]}}})', | ||
| 'hit_buffer_size': ' .dib_hit_buffer_size({DIB[inorder_width]})', |
There was a problem hiding this comment.
Could you add a couple tests to test/python/instantiation_file.py? At the very least, I'd like to cause a merge conflict with #564 and make sure Maccoy doesn't accidentally regress this.
There was a problem hiding this comment.
Yes, this will need added to the legacy environment module (explicit should have already fixed this by design).
There was a problem hiding this comment.
What would you prefer here? Would it be better to hold off on this until after #564? It probably has at least a couple more weeks left on it. Or would it be better to put this in real quick and make sure that the legacy environment handles it?
There was a problem hiding this comment.
You can go ahead and merge this at will, I will add it into the legacy environment when needed.
Author: Easyoakland Committer: GitHub make dib_inorder_width and dib_hit_buffer_size configurable (#696) Make `dib_inorder_width` and `dib_hit_buffer_size` configurable with the config.json. I was trying to configure champsim to get an unrealistically high IPC just to confirm that there aren't missing pieces in my understanding of how everything works and found I couldn't make IPC above 5. I believe the culprit is these configuration values being hard-coded.
4 participants
Make
dib_inorder_widthanddib_hit_buffer_sizeconfigurable with the config.json.I was trying to configure champsim to get an unrealistically high IPC just to confirm that there aren't missing pieces in my understanding of how everything works and found I couldn't make IPC above 5. I believe the culprit is these configuration values being hard-coded.