Fix ptpage - with test#688
Merged
ngober merged 4 commits intoChampSim:developfrom Feb 14, 2026
Merged
Conversation
ngober
approved these changes
Feb 14, 2026
github-actions Bot
added a commit
that referenced
this pull request
Feb 14, 2026
Author: maccoymerrell Committer: GitHub Fix ptpage - with test (#688) Added test to the fix proposed by @gh1403. This test ensures that re-references to the same page at the same level does not result in the allocation of new pages, unexpected misses, or inconsistent mappings. A GENERATE statement was used to check a collection of 5 page numbers instead of just 1, and each page may or may not be re-referenced 10 times following allocation to ensure the above behavior. --------- Co-authored-by: root <[email protected]> Co-authored-by: Nathan Gober <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added test to the fix proposed by @gh1403.
This test ensures that re-references to the same page at the same level does not result in the allocation of new pages, unexpected misses, or inconsistent mappings.
A GENERATE statement was used to check a collection of 5 page numbers instead of just 1, and each page may or may not be re-referenced 10 times following allocation to ensure the above behavior.