Explicitly cast uint64_t to double#681
Merged
ngober merged 1 commit intoChampSim:developfrom Jan 8, 2026
Merged
Conversation
Implicit cast of uint64_t to double results in -Wconversion because it may truncate values. However, truncatation never happens for the particular instances of inc/listeners/heartbeat.h, so tell that to the compiler with explicitly cast.
ngober
approved these changes
Jan 8, 2026
github-actions Bot
added a commit
that referenced
this pull request
Jan 8, 2026
Author: Nathan Gober Committer: GitHub Merge pull request #681 from akihikodaki/cast Explicitly cast uint64_t to double
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicit cast of uint64_t to double results in -Wconversion because it may truncate values. However, truncatation never happens for the particular instances of inc/listeners/heartbeat.h, so tell that to the compiler with explicitly cast.