Skip to content

Avoid using a C++20 feature#680

Merged
ngober merged 2 commits intoChampSim:developfrom
akihikodaki:lambda
Jan 9, 2026
Merged

Avoid using a C++20 feature#680
ngober merged 2 commits intoChampSim:developfrom
akihikodaki:lambda

Conversation

@akihikodaki
Copy link
Copy Markdown
Contributor

Lambda template is a C++20 feature.

Copy link
Copy Markdown
Collaborator

@ngober ngober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I saw this earlier, but the testing compilers seemed to tolerate it, so I left it in.

Also, I must have seen this earlier, but it's more generic to pass the variadic arguments as forwarding references (Args&&..., then std::forward<Args>(args)... at the call site. While we're in here, would you change them?

Comment thread inc/event_listeners.h Outdated
@akihikodaki
Copy link
Copy Markdown
Contributor Author

You're right. I saw this earlier, but the testing compilers seemed to tolerate it, so I left it in.

I found a warning for it noisy and wanted to remove it.

Also, I must have seen this earlier, but it's more generic to pass the variadic arguments as forwarding references (Args&&..., then std::forward<Args>(args)... at the call site. While we're in here, would you change them?

Done with commit f797b14.

@ngober ngober merged commit 8f20c37 into ChampSim:develop Jan 9, 2026
31 of 32 checks passed
github-actions Bot added a commit that referenced this pull request Jan 9, 2026
Author: Nathan Gober
Committer: GitHub

Merge pull request #680 from akihikodaki/lambda

Avoid using a C++20 feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants