Fix Issue #570: Unique if condition for impl_replacement_cache_fill#571
Open
ChristopherThomasHill wants to merge 1 commit intoChampSim:masterfrom
Open
Conversation
Contributor
|
This looks like it should resolve the issue. |
|
Finally getting through the backlog, looks good. Go ahead and merge it in. |
Collaborator
|
I don't want to merge this until the tests are written. Adding tests will ensure this issue doesn't come up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt at resolving Issue #570. It does have some code repetition issues, but does resolve the main bug with it not calling
update_replacement_state()for misses whenreplacement_cache_fill()isn't defined.