Fix #601: Passing chaiscript::ChaiScript reference to add_class for enumerations#686
Merged
lefticus merged 1 commit intoChaiScript:developfrom Apr 14, 2026
Conversation
…an add() method The operator functions in chaiscript::bootstrap::operators (equal, not_equal, assign, etc.) hardcoded Module& as their first parameter, preventing chaiscript::utility::add_class for enum types from working when passed a ChaiScript& reference directly. Added a second template parameter ModuleType to all operator functions so they accept any type that provides an add() method, matching the already-templatized add_class functions in utility.hpp. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
lefticus
approved these changes
Apr 14, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix by @leftibot.
What changed
Files
Closes #601
Triggered by @lefticus.