Skip to content

Joss-Submission#276

Merged
rlizzo merged 8 commits into
vmtk:masterfrom
rlizzo:joss
May 15, 2018
Merged

Joss-Submission#276
rlizzo merged 8 commits into
vmtk:masterfrom
rlizzo:joss

Conversation

@rlizzo

@rlizzo rlizzo commented May 8, 2018

Copy link
Copy Markdown
Member

@lantiga please find attached my draft paper for submission of VMTK 1.4 to the Journal of Open Source Software. The current status satisfies the author guidelines: https://joss.theoj.org/about#author_guidelines, and sits at about 750 words. This shouldn't take long, a quick review would be appreciated!

What I need from you:

  1. General review of paper.md for clarity and wording.
  2. Your ORCID ID from https://orcid.org/ (sorry, I wasn't able to find you there)
  3. If you would like anyone else listed as an author on the paper or in the acknowledgments section.

Once you give me your ORCID ID and I get the go ahead to merge, I'll handle submission and manage the review process. Thanks

@rlizzo rlizzo requested a review from lantiga May 8, 2018 10:13
Comment thread doc/joss-paper/paper.md Outdated
developer’s point of view.

``VMTK`` is a mature package with an active development team and user
community. It can be used via it's standalone interface, included as a Python

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its

Comment thread doc/joss-paper/paper.md Outdated
``VMTK`` is a mature package with an active development team and user
community. It can be used via it's standalone interface, included as a Python
or C++ library, or as an extension to the medical image processing platform 3D
Slicer. It has received 41 citations in scientific publications since its

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3D Slicer's ref?

Comment thread doc/joss-paper/paper.md Outdated
``VMTK`` is a mature package with an active development team and user
community. It can be used via it's standalone interface, included as a Python
or C++ library, or as an extension to the medical image processing platform 3D
Slicer. It has received 41 citations in scientific publications since its

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread doc/joss-paper/paper.md Outdated
The input surface representation (left), a visualization of the internal subset
of the voronoi diagram where each sheet represents a maximum inscribed sphere
radius centered at some point in the surface (center), the centerline extracted
from the voronoi diagram rendered as in it's position within the input surface

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its

Comment thread doc/joss-paper/paper.md Outdated
from the voronoi diagram rendered as in it's position within the input surface
(right).

## Splitting a Surface from it's Centerlines

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its :-)

Comment thread doc/joss-paper/paper.md Outdated
## Generating a Volumetric Mesh from a Surface

Tetrahedral, mixed tetrahedral, and boundary layer meshes can be generated from
a surface and it's centerlines.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its

Comment thread doc/joss-paper/paper.md

![pypepad](pypepad.png)

The VMTK PypePad user interface.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? PypePad? The swan song uh?

Comment thread doc/joss-paper/paper.md
infrastructure contributions from the team at Kitware Inc. (www.kitware.com).
In addition we would like to acknowledge Orobix Srl. (www.orobix.com) for
partially funding continued development efforts of ``VMTK``.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to acknowledge the main contributors listed in the source files, if there's room.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@lantiga lantiga left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! A few very minor changes inline

@rlizzo rlizzo merged commit 7625123 into vmtk:master May 15, 2018
@rlizzo rlizzo deleted the joss branch May 21, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants