Repository navigation
Cap the EF Core dependency below the next major - #8
Merged
Merged
Conversation
This package subclasses MigrationsModelDiffer and calls EF1001-marked internals, which EF documents as changeable or removable without notice in any release. The declared dependency was open-ended (>= 10.0.0), so NuGet would happily resolve EF Core 11 for a consumer and the differ could break at design time — surfacing as a confusing `dotnet ef` failure in someone else's project, never here. Npgsql.EntityFrameworkCore.PostgreSQL and EFCore.NamingConventions both declare [x, 11.0.0) for the same reason; this matches them. The lower bound stays at 10.0.0. NuGet resolves the lowest version in a range, so nothing changes for anyone already on EF Core 10 — the packed nuspecs now read [10.0.0, 11.0.0) and restore still picks 10.0.0. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last item from the repository review.
>= 10.0.0with no ceiling let NuGet resolve EF Core 11 for a consumer. Since this package subclassesMigrationsModelDifferand usesEF1001internals — explicitly changeable without notice in any release — that break would land in someone else'sdotnet efrun and never be visible from here.Matches what Npgsql.EntityFrameworkCore.PostgreSQL and EFCore.NamingConventions declare.
Abstractions >= 10.0.0Abstractions [10.0.0, 11.0.0)Npgsql.EFCore.PostgreSQL >= 10.0.0[10.0.0, 11.0.0)EFCore.SqlServer >= 10.0.0[10.0.0, 11.0.0)No change for existing consumers: NuGet resolves the lowest version in a range, so restore still picks 10.0.0.
Verification
dotnet list packageconfirms resolution still lands on 10.0.0