Release 5.4.0 - #32

Fixes to what 5.x already ships, found while testing the packages against EF Core 11 rc.1: JSON-member indexes that no query could use, and constraint names that only failed — or quietly vanished — when the migration was applied. The previously planned 5.4.0 scope (generic descriptor differ, delete constraint) moves to 5.5.0.

Changes

JSON-member indexes are written the way Npgsql's queries read the member (0b5a8d1, 127ff6d)

• PostgreSQL uses an expression index only for a query whose expression matches. Every member was rendered as "doc" -> 'A' ->> 'B' text with no cast, which matched only a top-level string. Indexes on nested members (#>> '{A,B}' in the query) or typed members (CAST(… AS integer)) applied, enforced uniqueness, and served no query.
• Members now render exactly as NpgsqlQuerySqlGenerator renders them (identical in Npgsql 10 and 11): ->> / #>>, a cast to the store type unless it is a string mapping, decode(…, 'base64') for bytea, jsonb for a primitive collection or a json/jsonb member. This applies to index parts, typed expression indexes and index filters; exclusion constraint filters keep their rendering.
• Rollout: parts are resolved at diff time on both sides, so a rendering change alone never produces a migration. Every declaration now writes CustomIndex:RenderingVersion onto the model; a snapshot without it is rendered by the old rules, so each affected index is dropped and re-created once, under its existing name.
• Default names come from the path, never from the rendered SQL, so no index is renamed.
• ResolvedIndexPart equality ignores the new internal metadata, so identical SQL never rebuilds.
• Date/time members stay text, because their casts are not IMMUTABLE. A non-unique index that starts with one is rejected at migrations add; unique ones are allowed.

Names checked across kinds on PostgreSQL (3c8e11b, roadmap D0)

• Constraint names are checked per table (42710) and index names per schema (42P07). The index behind every PK, unique, exclusion and temporal constraint counts as an index name.
• Against an exclusion constraint a clash did not fail at all. Its DROP CONSTRAINT IF EXISTS removed a same-named temporal constraint. Confirmed on PostgreSQL 18: the migration applied clean and only the EXCLUDE remained.
• Only collisions involving this package's declarations are reported, on the target model only.

Consumer-visible effects

• After upgrading, the first migrations add rebuilds the affected JSON-member indexes. Until that migration exists, has-pending-model-changes reports changes and Migrate() raises EF Core's pending-model-changes error.
• On large tables, declare IsCreatedConcurrently() before generating that migration. The custom generator renders CONCURRENTLY outside a transaction.
• Snapshots gain one HasAnnotation("CustomIndex:RenderingVersion", 2) line, which causes no DDL on its own.
• New rejections at migrations add: a non-unique index leading with a date/time JSON member, and name collisions.

Verification

• Tests: 328 pass on net10.0, including 9 against PostgreSQL 18.
• Guards: every new check was reverted once, and its tests failed for the intended reason.
  • Rendering: reverting it fails 11 tests; the live one reports ux_ig_tenants_city is not used: Seq Scan.
  • Rollout marker: 3 tests. Name tokens: 2. Part equality: 2. Exclusion pinning: 3. Date/time check: 2. Name registry: 8. jsonb members: 1.
• Alignment: rendering is asserted against EF's own ToQueryString() for every member type, so a future Npgsql translation change fails a test.
• Rollout: checked on a real Roslyn-compiled snapshot, both with and without the marker.
• On a live database: PostgreSQL 18 EXPLAIN with enable_seqscan = off shows EF's queries using nested, int, decimal, bool and enum member indexes.
• Delivery: the consumer smoke test passes against the packed 5.4.0, and dotnet pack -c Release validates cleanly against the 5.3.0 baseline.
• Review: migration-safety-review was run over the branch. It found the jsonb-member case (127ff6d) and confirmed that the stock generator still fails loudly via the sentinel, that the marker alone yields zero operations, and that real, character(1), smallint, interval, timestamptz and time line up with the query translation.

Not in this PR

• SQLite index names are database-wide, but the core differ checks them per table. This is tracked separately.
• ROADMAP.md corrections: the sixth MigrationsModelDiffer ctor parameter is EF 12, not 11; the [Obsolete] temporal constants item is moot (the class is internal and the generator still reads them for pre-5.0.2 migrations); and the 5.4.0/5.5.0 split.

🤖 Generated with Claude Code