This repository was archived by the owner on Nov 29, 2019. It is now read-only.
Taxonomy translate devas 1625#468
Merged
Merged
Conversation
vincentfretin
commented
Jul 11, 2018
| graphql(UpdateHarvestingTranslationPreference, { | ||
| name: 'updateHarvestingTranslation' | ||
| }) | ||
| )(DumbPostBody); No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Don't use redux connect here for perf reason. There is a comment about it in common/post/index.jsx, this applies to children down the tree.
| handleMouseUpWhileHarvesting={[Function]} | ||
| id="XYZ333" | ||
| isHarvesting={false} | ||
| isHarvesting={undefined} |
Contributor
Author
There was a problem hiding this comment.
This is strange that this is now undefined.
| if (connectedUserId && isHarvesting) { | ||
| // TODO check if the phase identifier (displayed phase: see the URL) is in ['thread', 'multiColumns'] | ||
| // const isHarvestablePhase = HARVESTABLE_PHASES.includes(getDisplayedPhaseIdentifier()) | ||
| if (connectedUserId && isHarvesting /* && isHarvestablePhase */) { |
| with context.begin_transaction(): | ||
| op.add_column( | ||
| 'extract', | ||
| sa.Column('lang', sa.String(20), nullable=False)) |
Contributor
Author
There was a problem hiding this comment.
This should be a foreign key to locale table I think.
Contributor
Author
|
The lang field on extract table should have been a foreign key to locale table I think. |
Contributor
Author
|
The backend part should have been based on the work done in #399 no? cc @ayyazdaniaryan |
vincentfretin
force-pushed
the
taxonomyTranslate_DEVAS-1625
branch
from
026107e to
8b0e691
Compare
amensouissi
force-pushed
the
taxonomyTranslate_DEVAS-1625
branch
2 times, most recently
from
9c39152 to
d4875c9
Compare
amensouissi
force-pushed
the
taxonomyTranslate_DEVAS-1625
branch
from
500f5aa to
6d294eb
Compare
…from the postBody
…sting and the displayed phase is harvestable
amensouissi
force-pushed
the
taxonomyTranslate_DEVAS-1625
branch
from
6d294eb to
dec7070
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.