Skip to content

feat: Java 21 modernization — worldwindx.examples - #20

Open
devin-ai-integration[bot] wants to merge 3 commits into
developfrom
devin/java21-worldwindx-examples
Open

feat: Java 21 modernization — worldwindx.examples#20
devin-ai-integration[bot] wants to merge 3 commits into
developfrom
devin/java21-worldwindx-examples

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented May 26, 2026 •
edited by staging-devin-ai-integration Bot
Loading

Copy link
Copy Markdown

Description of the Change

Applies conservative Java 21 pattern matching for instanceof in the worldwindx.examples and worldwindx.performance example packages.

Changed files:

  • src/gov/nasa/worldwindx/examples/BulkDownloadPanel.java
  • src/gov/nasa/worldwindx/examples/KeepingObjectsInView.java
  • src/gov/nasa/worldwindx/examples/ScreenSelection.java
  • src/gov/nasa/worldwindx/examples/WorldWindDiagnostics.java

Before/after counts for this package scope:

  • new Runnable(): 93 → 93
  • new ActionListener(): 94 → 94
  • new Callable(): 0 → 0
  • new MouseListener(): 1 → 1
  • new KeyListener(): 0 → 0
  • new ChangeListener(): 47 → 47
  • new PropertyChangeListener(): 16 → 16
  • new WindowListener(): 0 → 0
  • instanceof locations: 214 → 214 (7 cast sites modernized)
  • Records introduced: 0
  • Sealed hierarchies introduced: 0
  • Deprecated API removals: 0
  • Text block conversions: 0

Verification:

  • ant -f release-build.xml under JDK 21: BUILD SUCCESSFUL
  • Test result: 435 tests, 0 failures, 0 errors, 7 skipped
  • Public/protected API diff check: no added public/protected declarations
  • Test files modified: none

Devin session: https://app.devin.ai/sessions/36287b7c637242dba0a6a659737d5402

Devin Review verdict: local verification passed; no automated CI checks are configured on this fork.

Flagged for human review: the many remaining anonymous Swing listeners/Runnables in examples are intentionally left unchanged because the package includes UI/event-thread examples where this binding and callback semantics should be reviewed case-by-case.

Why Should This Be In Core?

The examples compile with the core distribution and should remain source-compatible with the Java 21 retarget. This PR removes redundant casts in safe spots while avoiding broad UI callback refactors.

Benefits

  • Modernizes straightforward example cast paths.
  • Keeps the Wave 4 examples/applications split atomic.
  • Maintains the existing full JDK 21 release-build test profile.

Potential Drawbacks

  • Most listener-heavy example code remains intentionally unchanged.
  • No functional behavior changes are intended.

Applicable Issues

N/A

Requested by: @jakexcosme

Devin Review

Status Commit
⚪ Not started —

Run Devin Review

💡 Connect your GitHub account to enable automatic code reviews.

Open in Devin Review (Staging)

@devin-ai-integration

devin-ai-integration Bot commented May 26, 2026

Copy link
Copy Markdown
Author
Original prompt from Jake

#``# Overview

Migrate COG-GTM/WorldWindJava from Java 11 to Java 21 LTS. This is a federal-grade, zero-breakage migration with atomic per-package PRs, full test verification before and after, and a rollup audit document. Use parallel child sessions to accelerate. All PRs target the fork's develop branch.

#``# PHASE 0: Pre-Migration Baseline (Sequential — MUST complete before anything else)

#``#``# Step 0.1: Capture Pre-Migration Baseline Metrics
Before ANY changes, on the develop branch with JDK 11:

`#` File count
find src -name "*.java" | wc -l
`#` Anonymous inner class counts
grep -rn "new Runnable()" --include="*.java" src/ | wc -l
grep -rn "new ActionListener()" --include="*.java" src/ | wc -l
grep -rn "new Callable()" --include="*.java" src/ | wc -l
grep -rn "new MouseListener()" --include="*.java" src/ | wc -l
grep -rn "new KeyListener()" --include="*.java" src/ | wc -l  
grep -rn "new ChangeListener()" --include="*.java" src/ | wc -l
grep -rn "new PropertyChangeListener()" --include="*.java" src/ | wc -l
grep -rn "new WindowListener()" --include="*.java" src/ | wc -l
`#` instanceof pattern-match candidates
grep -rn "instanceof " --include="*.java" src/ | wc -l
`#` Deprecated usage
grep -rn "`@`Deprecated" --include="*.java" src/ | wc -l
grep -rn "new Integer(" --include="*.java" src/ | wc -l
grep -rn "new Double(" --include="*.java" src/ | wc -l
grep -rn "new Float(" --include="*.java" src/ | wc -l
grep -rn "new Long(" --include="*.java" src/ | wc -l
grep -rn "new Boolean(" --include="*.java" src/ | wc -l

Save all counts to a file BASELINE-METRICS.txt at the repo root. This is your "before" snapshot.

#``#``# Step 0.2: Run the existing test suite under JDK 11

ant -f release-build.xml

Record pass/fail counts. This establishes that the test suite is green BEFORE migration.

#``# PHASE 1: Foundational JDK 21 Retarget PR (Sequential — Wave 0)

#``#``# Step 1.1: Create branch devin/java21-foundation
Make these changes ONLY (no code changes):

  1. **`release-... (12653 chars truncated...)

@devin-ai-integration

devin-ai-integration Bot commented May 26, 2026

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

See More

@jakexcosme jakexcosme

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakexcosme