Skip to content

feat: Java 21 modernization — root small packages - #17

Open
devin-ai-integration[bot] wants to merge 3 commits into
developfrom
devin/java21-root-small
Open

feat: Java 21 modernization — root small packages#17
devin-ai-integration[bot] wants to merge 3 commits into
developfrom
devin/java21-root-small

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented May 26, 2026 •
edited by staging-devin-ai-integration Bot
Loading

Copy link
Copy Markdown

Description of the Change

Applies Java 21 pattern matching for instanceof in the top-level gov.nasa.worldwind package and small helper packages (avlist, drag, exception, pick, poi, tracks).

Changed files:

  • src/gov/nasa/worldwind/AbstractSceneController.java
  • src/gov/nasa/worldwind/BasicFactory.java
  • src/gov/nasa/worldwind/BasicModel.java
  • src/gov/nasa/worldwind/BasicSceneController.java
  • src/gov/nasa/worldwind/avlist/AVListImpl.java
  • src/gov/nasa/worldwind/drag/DraggableSupport.java

Before/after counts for this package scope:

  • new Runnable(): 5 → 5
  • new ActionListener(): 1 → 1
  • new Callable(): 0 → 0
  • new MouseListener(): 0 → 0
  • new KeyListener(): 0 → 0
  • new ChangeListener(): 0 → 0
  • new PropertyChangeListener(): 0 → 0
  • new WindowListener(): 0 → 0
  • instanceof locations: 19 → 19 (16 cast sites modernized)
  • Records introduced: 0
  • Sealed hierarchies introduced: 0
  • Deprecated API removals: 0
  • Text block conversions: 0

Verification:

  • ant -f release-build.xml under JDK 21: BUILD SUCCESSFUL
  • Test result: 435 tests, 0 failures, 0 errors, 7 skipped
  • Public/protected API diff check: no added public/protected declarations
  • Test files modified: none

Devin session: https://app.devin.ai/sessions/36287b7c637242dba0a6a659737d5402

Devin Review verdict: local verification passed; no automated CI checks are configured on this fork.

Flagged for human review: existing anonymous Runnable/ActionListener instances were left unchanged because this PR focuses on safe type-pattern modernization only; no behavior-affecting SAM conversions were made in this scope.

Why Should This Be In Core?

This keeps the core WorldWind API source aligned with the JDK 21 retarget while preserving public API compatibility. The changes remove redundant casts without altering method signatures, inheritance, or runtime behavior.

Benefits

  • Uses standard Java 21 pattern matching to reduce cast boilerplate.
  • Keeps modernization atomic to root/small helper packages.
  • Maintains the existing test profile under JDK 21.

Potential Drawbacks

  • No functional behavior changes are intended.
  • Remaining anonymous classes are intentionally deferred/flagged rather than converted speculatively.

Applicable Issues

N/A

Requested by: @jakexcosme

Devin Review

Status Commit
⚪ Not started —

Run Devin Review

💡 Connect your GitHub account to enable automatic code reviews.

Open in Devin Review (Staging)

@devin-ai-integration

devin-ai-integration Bot commented May 26, 2026

Copy link
Copy Markdown
Author
Original prompt from Jake

#``# Overview

Migrate COG-GTM/WorldWindJava from Java 11 to Java 21 LTS. This is a federal-grade, zero-breakage migration with atomic per-package PRs, full test verification before and after, and a rollup audit document. Use parallel child sessions to accelerate. All PRs target the fork's develop branch.

#``# PHASE 0: Pre-Migration Baseline (Sequential — MUST complete before anything else)

#``#``# Step 0.1: Capture Pre-Migration Baseline Metrics
Before ANY changes, on the develop branch with JDK 11:

`#` File count
find src -name "*.java" | wc -l
`#` Anonymous inner class counts
grep -rn "new Runnable()" --include="*.java" src/ | wc -l
grep -rn "new ActionListener()" --include="*.java" src/ | wc -l
grep -rn "new Callable()" --include="*.java" src/ | wc -l
grep -rn "new MouseListener()" --include="*.java" src/ | wc -l
grep -rn "new KeyListener()" --include="*.java" src/ | wc -l  
grep -rn "new ChangeListener()" --include="*.java" src/ | wc -l
grep -rn "new PropertyChangeListener()" --include="*.java" src/ | wc -l
grep -rn "new WindowListener()" --include="*.java" src/ | wc -l
`#` instanceof pattern-match candidates
grep -rn "instanceof " --include="*.java" src/ | wc -l
`#` Deprecated usage
grep -rn "`@`Deprecated" --include="*.java" src/ | wc -l
grep -rn "new Integer(" --include="*.java" src/ | wc -l
grep -rn "new Double(" --include="*.java" src/ | wc -l
grep -rn "new Float(" --include="*.java" src/ | wc -l
grep -rn "new Long(" --include="*.java" src/ | wc -l
grep -rn "new Boolean(" --include="*.java" src/ | wc -l

Save all counts to a file BASELINE-METRICS.txt at the repo root. This is your "before" snapshot.

#``#``# Step 0.2: Run the existing test suite under JDK 11

ant -f release-build.xml

Record pass/fail counts. This establishes that the test suite is green BEFORE migration.

#``# PHASE 1: Foundational JDK 21 Retarget PR (Sequential — Wave 0)

#``#``# Step 1.1: Create branch devin/java21-foundation
Make these changes ONLY (no code changes):

  1. **`release-... (12653 chars truncated...)

@devin-ai-integration

devin-ai-integration Bot commented May 26, 2026

Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

See More

@jakexcosme jakexcosme

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jakexcosme