Commiting changes for thursday's challenge! by CJLucido · Pull Request #1 · CJLucido/JavaScript-IV

copied all of prototype.js into prototype-refactor.js

CJLucido

committed

9225b5a

converted GameObject to class with refactored prototype

CJLucido

committed

3197722

converted CharacterStats to class and refactored its prototype function to a class method

CJLucido

committed

f2ab86d

fixed semicolons in constructor functions to commas and converted Humanoid constructor to class with its prototype function refactored to a class method

CJLucido

committed

dcdf6fc

Humanoid now extends CharacterStats

CJLucido

committed

83102e2

converted Hero constructor Fn to class with prototype Fn refactored to a class method and Hero extends Humanoid

CJLucido

committed

cf9ce1b

converted Villain from constructor Fn to class, refactored prototype Fn to class method for villain, Villain now extends Humanoid, changed all super() to end in semicolons not commas. prototype-ref…

CJLucido

committed

736b0b9

created Person class in lambda-classes.js

CJLucido

committed

56ff4be

created a student string at global, created the Instructor class with methods as an extension of Person

CJLucido

committed

838a5d5

created a student class that extends person with attributes and methods

CJLucido

committed

57e3d8f

added this and subject/channel to some of the methods parameters, but they are currently in global- may have to move them to Person. Expect trouble with Student.favSubjects.reduce

CJLucido

committed

895e57a

created Project Managers class as extension of Instructors, time to make objects and debug

CJLucido

committed

8bab274

changed Instructor Fn to call a student name and not 'this'

CJLucido

committed

3f42f35

fixed misspelling of Instructor from Instructors in PM extends, removed this as a param from class methods, added student object

CJLucido

committed

ffbc519

console.logged 3 student methods, all working

CJLucido

committed

4b157dd

retract last comment, listsSubjects is not working. Person method of speak is working

CJLucido

committed

e0a514a

added Instructor object and tested Instructor methods, both work

CJLucido

committed

bc4efa3

added PM object and tested PM methods, both work. ALMOST MVP at 1hr7min

CJLucido

committed

b28d3e7

almost fixed listsSubjects using this.favSubjects, returns one subject but then undefined

CJLucido

committed

83ce897

MVP, baby!

CJLucido

committed

9e0d571

MVP and Stretch!

CJLucido

committed

23e8a89

2 solutions for listsSubjects and fixes numbering issue

CJLucido

committed

1ecb46b

Navigation Menu

Commiting changes for thursday's challenge! - #1

Commiting changes for thursday's challenge!#1
CJLucido wants to merge 22 commits into
masterfrom
carlo-lucido

Commits on Sep 19, 2019

copied all of prototype.js into prototype-refactor.js

converted GameObject to class with refactored prototype

converted CharacterStats to class and refactored its prototype function to a class method

fixed semicolons in constructor functions to commas and converted Humanoid constructor to class with its prototype function refactored to a class method

Humanoid now extends CharacterStats

converted Hero constructor Fn to class with prototype Fn refactored to a class method and Hero extends Humanoid

converted Villain from constructor Fn to class, refactored prototype Fn to class method for villain, Villain now extends Humanoid, changed all super() to end in semicolons not commas. prototype-ref…

created Person class in lambda-classes.js

created a student string at global, created the Instructor class with methods as an extension of Person

created a student class that extends person with attributes and methods

added this and subject/channel to some of the methods parameters, but they are currently in global- may have to move them to Person. Expect trouble with Student.favSubjects.reduce

created Project Managers class as extension of Instructors, time to make objects and debug

changed Instructor Fn to call a student name and not 'this'

fixed misspelling of Instructor from Instructors in PM extends, removed this as a param from class methods, added student object

console.logged 3 student methods, all working

retract last comment, listsSubjects is not working. Person method of speak is working

added Instructor object and tested Instructor methods, both work

added PM object and tested PM methods, both work. ALMOST MVP at 1hr7min

almost fixed listsSubjects using this.favSubjects, returns one subject but then undefined

MVP, baby!

MVP and Stretch!

2 solutions for listsSubjects and fixes numbering issue