Commiting changes for thursday's challenge! - #1
Open
CJLucido wants to merge 22 commits into
Open
Conversation
…on to a class method
…manoid constructor to class with its prototype function refactored to a class method
…o a class method and Hero extends Humanoid
…Fn to class method for villain, Villain now extends Humanoid, changed all super() to end in semicolons not commas. prototype-refactor.js completed in 18 minutes
… methods as an extension of Person
… they are currently in global- may have to move them to Person. Expect trouble with Student.favSubjects.reduce
…ake objects and debug
…ed this as a param from class methods, added student object
…t but then undefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feeling real good about today, definitely need to use array methods more though just to be able to understand what they are doing faster when I go back to the documentation