Simplify docker image build process#25
Merged
Merged
Conversation
This is still a WIP, as we run into dependency problems caused by Deployer 6.x not having support for PHP ^8.0, see for example deployphp/deployer#3189. I think it would be wise to fork Deployer and make the 6.x branch compatible with PHP ^8.0. When Deployer 7 is released, we can start making use of that version for the PHP ^8.0 variant and fall back to Deployer 6.x for PHP 7.x. Changes that have been made: - Install box without Composer. With this change we didn't need the `build/` directory anymore, so it was deleted. - Just use one PHP image for both build and runtime - Install Node.js and NPM using nodesource rather than the Node.js Docker image - Removed dep sentry (in the future we need to implement our own APM) - Removed dep deployer/recipes, this packages is deprecated and we should make use of the recipes within the deployer/deployer package.
tdgroot
commented
Jul 26, 2022
tdgroot
commented
Jul 26, 2022
AlexanderGrooff
approved these changes
Aug 9, 2022
Comment on lines
+25
to
+30
| && curl -fsSL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add - \ | ||
| && echo "deb http://deb.nodesource.com/node_${NODE_VERSION}.x buster main" | tee /etc/apt/sources.list.d/nodesource.list \ | ||
| && echo \ | ||
| "Package: * \ | ||
| Pin origin deb.nodesource.com \ | ||
| Pin-Priority: 1001" > /etc/apt/preferences.d/nodejs |
Contributor
There was a problem hiding this comment.
Is this easier compared to just installing node from debian.hypernode.com?
Member
Author
There was a problem hiding this comment.
We don't have all the node versions available on our own repo, so that's why I chose to use nodesource directly.
| "deployer/recipes": "dev-master", | ||
| "doctrine/annotations": "^1.6", | ||
| "hypernode/deploy-configuration": "dev-master", | ||
| "hypernode/deploy-configuration": "^1.0.0", |
Contributor
There was a problem hiding this comment.
This will change again on the deployer v7 PR, but fine for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes that have been made:
build/directory anymore, so it was deleted.should make use of the recipes within the deployer/deployer package.
debian:busterimage