Tags: BunsDev/hyperframes
Tags
fix: guard layoutWidth/Height with HTMLElement instanceof check offsetWidth/offsetHeight are only defined on HTMLElement (not on SVGElement, MathMLElement, etc.). Casting unconditionally can yield undefined-by-runtime even though TypeScript thinks otherwise. Use an instanceof check and fall back to the bounding rect dimensions when the element is not an HTMLElement. Addresses deferred review feedback from PR heygen-com#290.
fix(hdr): address review feedback across stack - Document groupIntoLayers tie-break (V8 stable sort → DOM order). - Expand layerCompositor docstring: merge rationale, visibility inclusion. - Add tests: empty input, negative z-index, stable tie-break at equal z. - Document getEffectiveZIndex CSS stacking-context limitations. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
fix(hdr): address deferred items from PR heygen-com#288 review - blitRgb48leRegion: take canvasHeight as an explicit parameter so callers with non-square canvases or other byte-stride conventions cannot silently produce a wrong height. Updates all alphaBlit.test.ts call sites. - renderOrchestrator: cache max frame index per pre-extracted HDR frame directory and bounds-check videoFrameIndex before existsSync. Avoids redundant filesystem syscalls when the requested time falls past the last extracted frame for a given clip. Made-with: Cursor
test(engine): expand sampleRgb48le coverage + audit Uint16Array align… …ment Adds: - 8 new sampleRgb48le bilinear-interpolation tests covering boundary pixels, sub-pixel weights, edge clamping, and odd-byte-offset Buffers. - uint16-alignment-audit.test.ts documenting the alignment requirement for Uint16Array views over Buffer slices vs. readUInt16LE/writeUInt16LE. Background: ~105 hot-loop sites in shader transitions still use readUInt16LE/writeUInt16LE. Switching to Uint16Array views would cut overhead but requires guaranteed even byteOffsets — these tests document the contract before any future refactor lands.
PreviousNext