fix(sandbox): let cp copy into an existing remote directory - #143
Open
jedisct1 wants to merge 1 commit into
Open
fix(sandbox): let cp copy into an existing remote directory#143jedisct1 wants to merge 1 commit into
jedisct1 wants to merge 1 commit into
Conversation
Copying a file to a destination such as `my-sandbox:/tmp` used to fail with “Failed to write /tmp”, which was very confusing. Check the destination at both ends of the transfer so that, when it is a directory, the file is copied into it, as with regular shell commands. This also provides an opportunity to add a new `stat(path)` method to the SDK. It is useful here and will likely be useful for many other tasks as well.
|
@codex review |
🦋 Changeset detectedLatest commit: 624832c The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying a file to a destination such as
my-sandbox:/tmpused to fail with “Failed to write /tmp”, which was very confusing.Check the destination at both ends of the transfer so that, when it is a directory, the file is copied into it, as with regular shell commands.
This also provides an opportunity to add a new
stat(path)method to the SDK.It is useful here and will likely be useful for many other tasks as well.