Skip to content

Implement img_source() - #36

Merged
keviny2 merged 12 commits into
mainfrom
img-source
Apr 4, 2025
Merged

Implement img_source()#36
keviny2 merged 12 commits into
mainfrom
img-source

Conversation

@keviny2

@keviny2 keviny2 commented Mar 28, 2025

Copy link
Copy Markdown
Collaborator
  • Add img_source() in SpatialExperiment class
  • Add img_source() in each child class of VirtualSpatialExperiment

@keviny2 keviny2 self-assigned this Mar 28, 2025
@keviny2 keviny2 linked an issue Mar 28, 2025 that may be closed by this pull request
@keviny2
keviny2 requested a review from jkanche April 3, 2025 18:17
@keviny2

keviny2 commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator Author

@jkanche it would be great if you could take a look at this PR as it makes changes to the SpatialImage class which you wrote.

@jkanche jkanche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me.

This would be a separate issue, but we should have getters and setters to some of these accessors. Also need to spell them out image_sources etc.

@keviny2
keviny2 merged commit d9fb079 into main Apr 4, 2025
@keviny2
keviny2 deleted the img-source branch April 4, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement img_source()

2 participants