feat: explicit skipSigning flag for staging CI jobs - #77
Merged
Merged
Conversation
Add a Gradle property 'skipSigning' to explicitly disable Maven publication signing. The CI workflow passes this flag for pull_request builds where repository secrets are not available (e.g., Dependabot PRs from forks). This makes the signing behavior documented and consistent rather than silently skipping when keys are missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dependabot PRs were failing CI because the build unconditionally attempts to sign Maven publications, but PRs from forks don't have access to repository secrets (PGP signing keys).
Solution
Added a Gradle property
skipSigningto explicitly control whether signing is performed:skipSigningproperty before callingsignAllPublications()-PskipSigning=trueforpull_requestbuilds where secrets are unavailableBenefits