Fix: add signing env vars to CI build step - #18
Merged
Merged
Conversation
Add signing secrets to the CI build as a safety measure. While signing is skipped for SNAPSHOT versions, if the release workflow fails after committing the release version but before bumping to SNAPSHOT, the CI build would fail without these secrets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The CI build pipeline (github.yml) runs on pushes to main. The release workflow commits and pushes the release version (non-SNAPSHOT) before bumping to the next SNAPSHOT. This triggers a CI build with a non-SNAPSHOT version, which requires GPG signing.
Without the signing secrets, this CI build fails with "no configured signatory" error.
Changes
github.yml:ORG_GRADLE_PROJECT_signingInMemoryKeyORG_GRADLE_PROJECT_signingInMemoryKeyPassword