Fix: add signing env vars to library build step - #17
Merged
Merged
Conversation
The library build step runs 'publishToMavenLocal' with a non-SNAPSHOT version, which triggers GPG signing. Without the signing env vars, this fails with 'no configured signatory' error. The gradle plugin and example builds don't need signing because they don't have signAllPublications() configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The library build step runs
./gradlew build publishToMavenLocalafter the version has been changed from SNAPSHOT to a release version (e.g.,6.0.0-rc1). This triggers GPG signing becausesignAllPublications()is configured inbuild.gradleand the version no longer ends with-SNAPSHOT.Without the signing environment variables, the build fails with:
Changes
ORG_GRADLE_PROJECT_signingInMemoryKeyORG_GRADLE_PROJECT_signingInMemoryKeyPasswordTesting
Verified that:
Note: Removed
ORG_GRADLE_PROJECT_signingInMemoryKeyIdbecause the plugin requires it in short 8-character format, and it's optional (auto-detected from the key).