fix(ui): drop stray text next to Close in the model connection test dialog - #38852
Merged
yuneng-berri merged 1 commit intoAug 30, 2026
Conversation
…ialog The Add Model page's connection test dialog rendered a literal ", ]" beside the Close button, left over from converting an array of footer buttons into JSX children.
Contributor
Greptile SummaryThis PR removes unintended text beside the Close button in the model connection test dialog and adds a focused regression test.
Confidence Score: 5/5The PR appears safe to merge with no actionable regressions identified. The production change only deletes unintended static text, and the focused test directly verifies the corrected footer without altering runtime behavior.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/add_model/AddModelForm.tsx | Removes only the unintended static footer text while preserving the Close button and dialog behavior. |
| ui/litellm-dashboard/src/components/add_model/AddModelForm.test.tsx | Adds an appropriately scoped component regression test that opens the dialog and precisely checks its user-visible footer text. |
Reviews (1): Last reviewed commit: "fix(ui): drop stray text next to Close i..." | Re-trigger Greptile
ryan-crabbe-berri
approved these changes
Aug 30, 2026
yuneng-berri
deleted the
litellm_/model-test-connection-artifact-805be5
branch
August 30, 2026 00:30
galactic-batter Bot
pushed a commit
to codgician/litellm
that referenced
this pull request
Sep 1, 2026
…nection-artifact-805be5 fix(ui): drop stray text next to Close in the model connection test dialog (cherry picked from commit 8e45522)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
User Flow
Before: an admin testing a new model sees junk characters in the results dialog
After: the same dialog shows only the Close button
Relevant issues
Linear ticket
Pre-Submission checklist
uv run pytest tests/test_litellm/<your_test_file>.py -vDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Before (ff2f06e)
After (795c036)
Type
🐛 Bug Fix
Caveats (if any)
Final Attestation