Skip to content

fix(ui): drop stray text next to Close in the model connection test dialog - #38852

Merged
yuneng-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_/model-test-connection-artifact-805be5
Aug 30, 2026
Merged

yuneng-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_/model-test-connection-artifact-805be5

Conversation

@yuneng-berri

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • Connection test dialog shows a stray ", ]" next to Close

How it solves it:

  • Removes the leftover text node from the dialog footer
  • Adds a component test pinning the footer to just Close

User Flow

Before: an admin testing a new model sees junk characters in the results dialog

  1. They open http://localhost:4000/ui/?page=new_model and pick a provider, model, and key
  2. They click Test Connect
  3. The Connection Test Results dialog opens, and the footer reads "Close , ]" instead of just "Close"

After: the same dialog shows only the Close button

  1. They open http://localhost:4000/ui/?page=new_model and pick a provider, model, and key
  2. They click Test Connect
  3. The Connection Test Results dialog opens with a single Close button and no leftover characters

Relevant issues

Linear ticket

Pre-Submission checklist

  • I have added meaningful tests
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/test_litellm/<your_test_file>.py -v
  • My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

Screenshots / Proof of Fix

Before (ff2f06e)

After (795c036)

Type

🐛 Bug Fix

Caveats (if any)

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

…ialog

The Add Model page's connection test dialog rendered a literal ", ]" beside the Close button, left over from converting an array of footer buttons into JSX children.
@greptile-apps

greptile-apps Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes unintended text beside the Close button in the model connection test dialog and adds a focused regression test.

  • Removes the stray , ] text node from the dialog footer.
  • Verifies that the rendered footer contains only Close.

Confidence Score: 5/5

The PR appears safe to merge with no actionable regressions identified.

The production change only deletes unintended static text, and the focused test directly verifies the corrected footer without altering runtime behavior.

Important Files Changed

Filename Overview
ui/litellm-dashboard/src/components/add_model/AddModelForm.tsx Removes only the unintended static footer text while preserving the Close button and dialog behavior.
ui/litellm-dashboard/src/components/add_model/AddModelForm.test.tsx Adds an appropriately scoped component regression test that opens the dialog and precisely checks its user-visible footer text.

Reviews (1): Last reviewed commit: "fix(ui): drop stray text next to Close i..." | Re-trigger Greptile

@yuneng-berri
yuneng-berri merged commit 8e45522 into litellm_internal_staging Aug 30, 2026
75 checks passed
@yuneng-berri
yuneng-berri deleted the litellm_/model-test-connection-artifact-805be5 branch August 30, 2026 00:30
galactic-batter Bot pushed a commit to codgician/litellm that referenced this pull request Sep 1, 2026
…nection-artifact-805be5

fix(ui): drop stray text next to Close in the model connection test dialog

(cherry picked from commit 8e45522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants