Repository navigation
Conversation
added 6 commits
June 2, 2024 15:56
|
|
||
| // Метод проверяет, что строка - целое положительное число | ||
| private boolean isThisNumber(String input) { | ||
| return input.matches("^[1-9][0-9]*$"); |
There was a problem hiding this comment.
Ты сначала проверяешь строку на соответствие регулярке, а потом парсишь Integer.parseInt. Можно сразу строку распарсить в инт (только нужно в try-catch) и проверить на то, что оно больше нуля и сразу вернуть из функции это число, чтобы не выполнять лишние операции
|
|
||
| public class Calculator { | ||
| private int numberOfPersons; | ||
| private HashMap<String, Double> goodsAndPrices; |
There was a problem hiding this comment.
Выбор коллекции не кажется обоснованным. Каждый новый продукт по сути это новое значение в мапе, а мапа занимает больше памяти, чем обычный список. Поэтому кажется, что простой ArrayList подойдёт лучше для хранения какого-нибудь класса Product с двумя полями - названием и ценой
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.