forked from Arrexel/phpbash
-
Notifications
You must be signed in to change notification settings - Fork 0
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: robokoder/phpbash
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Arrexel/phpbash
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 3 files changed
- 4 contributors
Commits on Feb 2, 2018
-
Always use !empty() over isset() when you need to verify that the user has provided a value. The function empty() also checks if the variable is set. This prevent the user from sending an empty string. See here for more informations: https://stackoverflow.com/questions/7191626/isset-and-empty-what-to-use
Configuration menu - View commit details
-
Copy full SHA for 4568c98 - Browse repository at this point
Copy the full SHA 4568c98View commit details -
Revert empty() check to isset() for cmd
We still need to be able to pass an empty string to the terminal. It would be much more hack-n-slash to prevent sending a blank command, and I personally feel it is more like a real terminal when you are able to send a blank command. If empty() is used, the code would also need to be modified further to prevent it from returning the full console HTML, as it would fail the php check and never hit die() if a blank command is sent.
Configuration menu - View commit details
-
Copy full SHA for e68c651 - Browse repository at this point
Copy the full SHA e68c651View commit details -
Merge pull request Arrexel#13 from ArtyumX/patch-1
replaced isset() by !empty()
Configuration menu - View commit details
-
Copy full SHA for 8acf54b - Browse repository at this point
Copy the full SHA 8acf54bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecd129d - Browse repository at this point
Copy the full SHA ecd129dView commit details
Commits on Feb 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 003ce03 - Browse repository at this point
Copy the full SHA 003ce03View commit details -
Merge pull request Arrexel#15 from paralax/patch-1
spelling fix, no content changes
Configuration menu - View commit details
-
Copy full SHA for dd927ae - Browse repository at this point
Copy the full SHA dd927aeView commit details
Commits on Feb 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for f99b7dd - Browse repository at this point
Copy the full SHA f99b7ddView commit details -
Merge pull request Arrexel#16 from 20esaua/patch-1
Patch XSS in filename on upload
Configuration menu - View commit details
-
Copy full SHA for 46c93ea - Browse repository at this point
Copy the full SHA 46c93eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf3e591 - Browse repository at this point
Copy the full SHA bf3e591View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...master