Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: robokoder/phpbash
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Arrexel/phpbash
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 3 files changed
  • 4 contributors

Commits on Feb 2, 2018

  1. replaced isset() by !empty()

    Always use !empty() over isset() when you need to verify that the user has provided a value.
    The function empty() also checks if the variable is set. This prevent the user from sending an empty string. 
    See here for more informations: https://stackoverflow.com/questions/7191626/isset-and-empty-what-to-use
    artyuum authored Feb 2, 2018
    Configuration menu
    Copy the full SHA
    4568c98 View commit details
    Browse the repository at this point in the history
  2. Revert empty() check to isset() for cmd

    We still need to be able to pass an empty string to the terminal. It would be much more hack-n-slash to prevent sending a blank command, and I personally feel it is more like a real terminal when you are able to send a blank command. If empty() is used, the code would also need to be modified further to prevent it from returning the full console HTML, as it would fail the php check and never hit die() if a blank command is sent.
    Arrexel authored Feb 2, 2018
    Configuration menu
    Copy the full SHA
    e68c651 View commit details
    Browse the repository at this point in the history
  3. Merge pull request Arrexel#13 from ArtyumX/patch-1

    replaced isset() by !empty()
    Arrexel authored Feb 2, 2018
    Configuration menu
    Copy the full SHA
    8acf54b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ecd129d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Configuration menu
    Copy the full SHA
    003ce03 View commit details
    Browse the repository at this point in the history
  2. Merge pull request Arrexel#15 from paralax/patch-1

    spelling fix, no content changes
    Arrexel authored Feb 5, 2018
    Configuration menu
    Copy the full SHA
    dd927ae View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Patch XSS vuln

    20esaua authored Feb 14, 2018
    Configuration menu
    Copy the full SHA
    f99b7dd View commit details
    Browse the repository at this point in the history
  2. Merge pull request Arrexel#16 from 20esaua/patch-1

    Patch XSS in filename on upload
    Arrexel authored Feb 14, 2018
    Configuration menu
    Copy the full SHA
    46c93ea View commit details
    Browse the repository at this point in the history
  3. Patch XSS vuln

    Arrexel authored Feb 14, 2018
    Configuration menu
    Copy the full SHA
    bf3e591 View commit details
    Browse the repository at this point in the history
Loading