Skip to content

Bad exports naming for Directive/Component #2356

Closed

Description

@alexeagle

the top-level 'angular2/angular2' module re-exports Component as ComponentAnnotation. The actual Component class extends Directive. However, we re-export class Directive as DirectiveAnnotation, and the re-exported Directive is just a var declaration. This breaks the angular2.d.ts since it ends up with a Component extends Directive type, where Directive is not a class.

Current workaround is to export the Directive annotation into the .d.ts, but this breaks the application because only decorators should be exposed to JS application.

Activity

  1. added this to the alpha-29 milestone on Jun 19, 2015
  2. naomiblack commented on Jun 19, 2015

    @naomiblack
    Contributor

    @alexeagle we need to discuss how to prioritize this relative to other customer-facing issues -- might need to slip to alpha-30.

  3. rkirov commented on Jun 22, 2015

    @rkirov
    Contributor

    The workaround is in angular2.api.ts, when this bug is fixed that file should be removed.

  4. modified the milestones: alpha-29, alpha-31 on Jun 30, 2015
  5. modified the milestones: alpha-32, alpha-31 on Jul 6, 2015
  6. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  7. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions