Conversation
Notifications were silently dropped when the app was in the foreground on a different tab: BackgroundService short-circuited on isAppInBackground() and there was no foreground path. Add a system notification dispatch in useConnectionLifecycle that fires when the message lands in a tab other than the active one, gated on !backgroundService.isAppInBackground() to avoid duplicates. NotificationService.shouldNotify never consulted highlightService, so custom highlight words only affected UI rendering, not alerts. Check highlightService.isHighlighted() inside the notifyOnMentions branch and extend the MENTION sound path to fire on highlight matches too. Bump app to 1.9.34 / versionCode 139 and refresh dependencies: Firebase 24.1.1->25.1.0, RN community CLI 20.1.3->20.2.0, Reanimated 4.4.1->4.5.0, Worklets 0.9.2->0.10.0, plus patch releases for Transifex, bootsplash, IAP, keyboard-controller, nitro-modules, google-mobile-ads, testing-library, @types/node and prettier.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notifications were silently dropped when the app was in the foreground on a different tab: BackgroundService short-circuited on isAppInBackground() and there was no foreground path. Add a system notification dispatch in useConnectionLifecycle that fires when the message lands in a tab other than the active one, gated on !backgroundService.isAppInBackground() to avoid duplicates.
NotificationService.shouldNotify never consulted highlightService, so custom highlight words only affected UI rendering, not alerts. Check highlightService.isHighlighted() inside the notifyOnMentions branch and extend the MENTION sound path to fire on highlight matches too.
Bump app to 1.9.34 / versionCode 139 and refresh dependencies: Firebase 24.1.1->25.1.0, RN community CLI 20.1.3->20.2.0, Reanimated 4.4.1->4.5.0, Worklets 0.9.2->0.10.0, plus patch releases for Transifex, bootsplash, IAP, keyboard-controller, nitro-modules, google-mobile-ads, testing-library, @types/node and prettier.
Pull Request
Summary
Change Type
Verification
yarn format-checkyarn lint:ciyarn type-checkyarn test:ciList any additional manual verification performed:
Impact and Risk
UI Changes
Screenshots or recordings:
Checklist