Repository navigation
R4UBS - #1
Open
AndreyR4UBS wants to merge 1 commit into
Open
R4UBS#1AndreyR4UBS wants to merge 1 commit into
AndreyR4UBS wants to merge 1 commit into
Conversation
| @@ -0,0 +1,14 @@ | |||
| class Car { | |||
| private String name; | |||
There was a problem hiding this comment.
В этом классе оба поля можно сделать публичными и пометить их final - тогда можно удалить геттеры и получать доступ к полям напрямую по их имени - будет меньше кода, но также надёжно как с геттерами
| } | ||
| System.out.println("Самая быстрая машина : " + race.getCurrentLeader().getName()); | ||
| scanner.close(); | ||
| } private static String readCarName(Scanner scanner) { |
There was a problem hiding this comment.
Объявление функции лучше перенести на новую строку для повышения читабельности кода
| } | ||
| private static int readCarSpeed(Scanner scanner) { | ||
| int carSpeed; | ||
| while (true) { |
There was a problem hiding this comment.
Не рекомендую писать бесконечные циклы через while (true) - лучше всегда явно прописывать условие выхода из цикла, чтобы уменьшить вероятность ошибиться и повысить читабельность кода
| System.out.println("Введите скорость автомобиля (от 0 до 250 км/ч):"); | ||
| try { | ||
| carSpeed = scanner.nextInt(); | ||
| if (carSpeed >= 0 && carSpeed <= 250) { |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Это мой 2 Pull Request/ Сдача 2 спринта. На одну из самых известных автогонок в мире — «24 часа Ле-Мана»