Repository navigation
«24 часа Ле-Мана» - #1
Open
AnastasiShedar wants to merge 2 commits into
Open
AnastasiShedar wants to merge 2 commits into
AnastasiShedar wants to merge 2 commits into
Conversation
ArturNurtdinov
left a comment
ArturNurtdinov
left a comment
There was a problem hiding this comment.
Очень хорошая работа, молодец! Правильно используешь модификаторы private и final, так держать!
Comment on lines
+5
to
+6
| private final String name; // Нельзя изменить | ||
| private final int speed; |
There was a problem hiding this comment.
Так как строчки являются final, их можно спокойно делать публичными и не писать для них геттеры, а получать к ним доступ напрямую
| if (scanner.hasNextInt()) { // Проверка ввода числа | ||
| speed = scanner.nextInt(); | ||
| scanner.nextLine(); // Очистка буфера после nextInt() | ||
| if (speed > 0 && speed <= 250) { // Проверка диапазона |
There was a problem hiding this comment.
максимальную и минимальную допустимую скорости лучше вынести в константы для повышения читабельности кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
«24 часа Ле-Мана» — консольное приложение, которое будет задавать вопросы в консоли, считывать пользовательский ввод и в результате выводить победителя гонки.