Repository navigation
Conversation
gusar-off
reviewed
Nov 27, 2022
| String close; | ||
| while(true){ | ||
| System.out.println("Введите название блюда!"); | ||
| Scanner scSecond = new Scanner(System.in); |
There was a problem hiding this comment.
Лучшее переиспользовать инстанс сканнера, а не создавать каждый раз новый.
| public static String finish(float overallCost) { | ||
| String suffix; | ||
| int hundred = (int) Math.floor(overallCost % 100); | ||
| if (hundred <= 20 && hundred >= 5) { |
There was a problem hiding this comment.
Тут на самом деле достаточно будет интервала от 11 до 14 включительно, потому все остальные окончания будут совпадать
| if(price > 0 ){ | ||
| sumOfOrder = sumOfOrder + price; | ||
| String sufForOne = Finish.finish(price); | ||
| System.out.println("Вы добавили " + dish + " за " + price + sufForOne ); |
There was a problem hiding this comment.
В таких случаях для вывода лучше использоватьSystem.out.printf, ему можно передать параметры, которые будут поставлены в строку.
| System.out.println("Хотите добавить блюдо? Введите любую букву или напишите:'Завершить', если блюд больше не осталось"); | ||
| Scanner scFourth = new Scanner(System.in); | ||
| close = scFourth.next(); | ||
| if (close.equalsIgnoreCase("Завершить")){ |
There was a problem hiding this comment.
"Завершить" лучше вынести в статическую константу
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.