[OGUI-1924] Fix incorrectly called disableAutoScroll - #3636
Draft
isaachilly wants to merge 11 commits into
Draft
isaachilly wants to merge 11 commits into
isaachilly wants to merge 11 commits into
Conversation
The table scroll handler treated any decrease in scrollTop as the user scrolling up however this caught also just when the content shrunk which happens on switch from a full query mode to an initially empty live mode. Check now also if at the bottom of the page and if we still are then don't disableAutoScroll.
isaachilly
changed the title
Introduces a suite to cover autoscroll behaviour when users scroll, switch modes, and clear logs in both query and live mode.
Refactor the logs table mocha tests to wait for `autoScrollLive` state transitions with a shared helper instead of reading the value immediately.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
When clicking live mode after having ran a query that returns logs that don't fit in the visible window, the
onTableScrollevent listener fires and just after live mode has enabled autoScroll, it thinks the user has scrolled up, and disables it.Code:
Add another check that if we thinkt he user has scrolled up (by inbfering this from scrollTop change) then also check if the user is still at the bottom of the page. If they are, then do not consider this as the user scrolling up.
Reviewer: