[OGUI-746] url parameter direct livemode - #2708
Draft
Houwie7000 wants to merge 33 commits into
Draft
Houwie7000 wants to merge 33 commits into
Houwie7000 wants to merge 33 commits into
Conversation
Houwie7000
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
I found too much operating logic was occurring in the view so I have refactored the query/live button behaviour so that mode switching is handled by the model instead. This centralises the logic again and simplifies the view.
isaachilly
marked this pull request as draft
September 21, 2026 16:32
Await the needed information/processes calls and then start live mode if it was requested. Do not keep polling or manage a timeout etc.
Wait for the ws to either authenticate or close before auto-starting live mode, and skip the live transition if the connection drops first. Move `goLive()` error handling into `Log` so live mode entry reports failures consistently from both URL startup and UI toggles.
Centralise live/query availability logic in the log model. Update tab titles through mode changes. keep URL-driven live mode from starting when profile or invalid query params are used. Also adjust the live-mode test filter to match the expected enabled state.
Added browser tab title test for Query mode. Adding the browser tab test brought to light that runQueryWithMocks did not fully mock the real endpoint and if confirmReturn:true would error and leave queryResult as failure which broke the subsequent test. Mock data structure now updated to be inline with real endpoint.
Add a helper to fetch live-mode UI/model state in one page evaluation call. Also add an `after` hook to call `window.model.log.liveStop()` so live mode is always stopped after the suite.
Call `liveStart()` directly when entering live mode, and keep auto-scroll state updates quiet during live start/stop so mode changes no longer trigger extra notifications.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
Accept a
liveURL parameter. When it is set to true, attempt to start live mode as soon as its dependencies have loaded and allow.Needed so the AliECS GUI can link from a running environment to InfoLogger GUI in live mode with autoscroll (OGUI-722).
Code:
Previously, the Query/Live mode switching and their button styling were handled in the
commandLogsview bytoggleButtonStates, which stored the button state in module-level variables. Starting live mode from the URL meant interacting with the view to update these variables, which prom[ted a refactor to extract logic from the view to a model.activeMode.Logmodel.Reviewer:
The reviewer can test using this URL (remove runNumber to match more logs, but this is the specific use case the ticket mentions):
http://localhost:8080/?q=%7B%22timestamp%22%3A%7B%22since%22%3A%22-1h%22%7D%2C%22run%22%3A%7B%22match%22%3A%22248025%22%7D%2C%22severity%22%3A%7B%22in%22%3A%22I%20W%20E%20F%22%7D%7D&live=true
Note: