Conversation
This replaces the placeholder PDG code in omega2012Analysis.cxx with o2::constants::physics::Pdg::kOmega2012Minus, now that AliceO2 carries that constant. - Removes kPlaceholderPdgCode (3335) and its TODO.
sawenzel
requested review from
alibuild,
dmallick2,
mpuccio,
omvazque,
prottayCMT,
skundu692 and
smaff92
as code owners
September 28, 2026 15:59
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for fcf08b0 at 2026-09-28 18:29: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for fcf08b0 at 2026-09-28 19:00: Full log here. |
Collaborator
Collaborator
|
This seems already done in #17978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omega2012Analysis.cxxused a localkPlaceholderPdgCode = 3335with a TODO to switch to a real PDG constant once one existed. AliceO2#15820 addedo2::constants::physics::Pdg::kOmega2012Minus(123334); this switches the analysis to use it and drops the placeholder.