Skip to content

[O2B-1558] Set filters from url upon page reload#2144

Open
NarrowsProjects wants to merge 8 commits intoimpov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModelfrom
feature/O2B-1558/Set-filters-from-URL-upon-page-reload
Open

[O2B-1558] Set filters from url upon page reload#2144
NarrowsProjects wants to merge 8 commits intoimpov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModelfrom
feature/O2B-1558/Set-filters-from-URL-upon-page-reload

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 27, 2026 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • When a filters on overview pages are set, the active filters will appear in the url, when reloading the page, these filters will be applied automatically.

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 27, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 18.91892% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.79%. Comparing base (49ed030) to head (a6f2d45).

Files with missing lines Patch % Lines
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 15 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 10 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 9 Missing ⚠️
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 5 Missing ⚠️
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 4 Missing ⚠️
...mulationPass/RunsPerSimulationPassOverviewModel.js 0.00% 4 Missing ⚠️
...ataPasses/ActiveColumns/dataPassesActiveColumns.js 0.00% 2 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 2 Missing ⚠️
.../components/runEorReasons/runEorReasonSelection.js 0.00% 1 Missing ⚠️
...public/views/DataPasses/DataPassesOverviewModel.js 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files 
@@                                                             Coverage Diff                                                             @@
##           impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel    #2144      +/-   ##
===========================================================================================================================================
- Coverage                                                                                                    45.89%   45.79%   -0.10%     
===========================================================================================================================================
  Files                                                                                                         1036     1036              
  Lines                                                                                                        17167    17194      +27     
  Branches                                                                                                      3122     3128       +6     
===========================================================================================================================================
- Hits                                                                                                          7878     7874       -4     
- Misses                                                                                                        9289     9320      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects changed the base branch from main to impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel April 27, 2026 07:50
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1558/Set-filters-from-URL-upon-page-reload branch from 7bbf3b3 to 66294f2 Compare April 27, 2026 13:22
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1558/Set-filters-from-URL-upon-page-reload branch from 66294f2 to a6f2d45 Compare April 27, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta Awaiting requested review from graduta graduta is a code owner

@isaachilly isaachilly Awaiting requested review from isaachilly

Assignees

@NarrowsProjects NarrowsProjects

Labels

frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@NarrowsProjects