Skip to content

[MFT] Fix digi2raw output segmentation#8052

Merged
davidrohr merged 1 commit intoAliceO2Group:devfrom
rpezzi:MFTDigi2Raw
Feb 2, 2022
Merged

[MFT] Fix digi2raw output segmentation#8052
davidrohr merged 1 commit intoAliceO2Group:devfrom
rpezzi:MFTDigi2Raw

Conversation

@rpezzi
Copy link
Copy Markdown
Collaborator

@rpezzi rpezzi commented Feb 1, 2022

This PR adapts the MFT MC to raw converter to produce one file per CRU endpoint. o2-mft-digi2raw --file-for cru produces the following raw files:

MFT_alio2-cr1-flp182_cru567_0.raw
MFT_alio2-cr1-flp182_cru567_1.raw
MFT_alio2-cr1-flp182_cru570_0.raw
MFT_alio2-cr1-flp182_cru570_1.raw
MFT_alio2-cr1-flp183_cru548_0.raw
MFT_alio2-cr1-flp183_cru548_1.raw
MFT_alio2-cr1-flp183_cru554_0.raw
MFT_alio2-cr1-flp183_cru554_1.raw
MFT_alio2-cr1-flp184_cru543_0.raw
MFT_alio2-cr1-flp184_cru543_1.raw
MFT_alio2-cr1-flp184_cru569_0.raw
MFT_alio2-cr1-flp184_cru569_1.raw
MFT_alio2-cr1-flp185_cru541_0.raw
MFT_alio2-cr1-flp185_cru541_1.raw
MFT_alio2-cr1-flp185_cru552_0.raw
MFT_alio2-cr1-flp185_cru552_1.raw
MFT_alio2-cr1-flp186_cru542_0.raw
MFT_alio2-cr1-flp186_cru542_1.raw
MFT_alio2-cr1-flp186_cru547_0.raw
MFT_alio2-cr1-flp186_cru547_1.raw

@shahor02
Copy link
Copy Markdown
Collaborator

shahor02 commented Feb 1, 2022

Hi @sawenzel, @davidrohr ,

If I interpret the fullCI log correctly, it has failed due to the analysis test returning 1 instead of 1, which seems to be something recently added:

++ SIM_CHALLENGE_ANATESTING=ON
++ /sw/slc8_x86-64/O2/8052-slc8_x86-64-local1/prodtests/sim_challenge.sh
++ grep 'Return status' sim-challenge.log
++ grep -v ': 0'
Return status of MCHistograms: 1
++ false

@benedikt-voelkel
Copy link
Copy Markdown
Contributor

benedikt-voelkel commented Feb 1, 2022

Hej @shahor02
The analysis testing was not working properly actually and we fixed that for the first in #8046. After that, the introduction of the versioned MCParticle table caused a failure of the analysis tests in the fullCI. @jgrosseo fixed everything related to that and it was tested again (with 2 other analyses failing for related reasons).
In #8054 we see that all analyses pass now. So also here it should be green when tested again I reckon.
I will propagate this info tomorrow to one or two appropriate mattermost channels.

For clarification: The expected return value is 0 in which case no output is printed.

@davidrohr
Copy link
Copy Markdown
Collaborator

I don't really understand how this change in digi2raw can break the sim challenge.

@davidrohr
Copy link
Copy Markdown
Collaborator

OK, thx, that explains it, will wait for the CI to rerun and then merge.

@shahor02
Copy link
Copy Markdown
Collaborator

shahor02 commented Feb 1, 2022

Hi @benedikt-voelkel
thanks for the info (I had typo in my comment, should have been failed due to the analysis test returning 1 instead of 0). I see that the test finished in the morning, let's see if at next test it gets green.

Copy link
Copy Markdown
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, and output looks good.

@davidrohr davidrohr merged commit 717a440 into AliceO2Group:dev Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants