Various performance improvements.#60
Merged
AliSoftware merged 5 commits intoAliSoftware:masterfrom Aug 15, 2012
Merged
Conversation
Previously, an NSMutableArray was always being allocated, even if the label ultimately had no custom links. This defers the array allocation until it's actually needed.
We don't need to make a local mutable (and autoreleased) copy of our attributed string in attributedTextWithLinks. Instead, we can operate directly on our _attributedText ivar. This change also adds some early-out conditions that let us avoid the bulk of the processing code when we don't have any links to set.
Previously, we were checking for the selector on every enumeration block callback.
AliSoftware
added a commit
that referenced
this pull request
Aug 15, 2012
Various performance improvements.
stegiorgi
pushed a commit
to wedoit-io/OHAttributedLabel
that referenced
this pull request
Jan 21, 2014
- MBProgressHUD now requires LLVM 3+ - instance variables moved to the class implementation or removed (using synthesized instance vars) - using KVO instead of custom accessors - completely rewritten layout and UI buildup code - more concise arc conditionals - added MBProgressHUDModeText (+ example) - various documentation fixes - migrated to @autoreleasepool - general source code cleanup and restructuring - removed deprecated delegate callback - version bump to 5.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the individual commits for descriptions.