Repository navigation
Conversation
gusar-off
reviewed
Mar 16, 2023
| static int i = 0; //счётчик количества товаров | ||
|
|
||
| public static void calculate() { | ||
| Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
Лучшее переиспользовать инстанс Scanner, а не создавать каждый раз новый.
| public static String GetRuble(double num){ | ||
| int desayt = ((int) num % 100) / 10; | ||
| if (desayt == 1) | ||
| { |
There was a problem hiding this comment.
В Java переносить открывающую фигурную скобку в if/switch/методе не нужно
| return "рублей"; | ||
| } | ||
|
|
||
| switch ((int)num % 10) |
There was a problem hiding this comment.
Чтобы не дублировать приведение типов (int)num можно сделать один раз и сохранить результат в переменную
|
|
||
| System.out.println("Добавленные товары:\n" + Calculate.allItem); | ||
| System.out.println("Всего людей: " + people); | ||
| System.out.println(String.format(tempPrice, Calculate.allPrice) + " " + Format.GetRuble(Calculate.allPrice)); |
There was a problem hiding this comment.
Если используешь String.format можно избавиться от конкатенации через оператор +, подставив нужные параметры в паттерн
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Добрый день! Сдача приложения на первую проверку.