Repository navigation
Conversation
i-masloed
reviewed
Feb 11, 2024
| } | ||
|
|
||
| class SplitBill { // основной класс | ||
| Scanner scanner = new Scanner(System.in); |
There was a problem hiding this comment.
- хорошей практикой является делать вызов scanner.close() после того, как сканнер больше не используется. Это необходимо для того, что бы этот объект не потреблял ресурсы, тогда когда это уже не требуется.
| } | ||
| } | ||
|
|
||
| class Product { |
There was a problem hiding this comment.
Рекомендация: в java принято правило: один класс-один файл.
| } | ||
|
|
||
| private String rublesEnd(double rubles) { // процедура возвращает слово рубль с правильным окончанием | ||
| if (((int) rubles % 100) > 10 && ((int) rubles % 100) < 21 ) { |
There was a problem hiding this comment.
rubles % 100 и rubles % 10 используется несколько раз , стоит вынести в переменную
| int i = (int) rubles % 10; // выясняем последнюю цифру | ||
| if (i == 1) { | ||
| return "рубль"; | ||
| } else if (i == 2 || i == 3 || i == 4) { |
| } else if (i == 2 || i == 3 || i == 4) { | ||
| return "рубля"; | ||
| } else { | ||
| return "рублей"; |
There was a problem hiding this comment.
строковые значения можно вынести в константы
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request для сдачи калькулятора разделения счета.