Repository navigation
Flag deferred pillars; document that Cascade Stroke 1 can drop true hits - #346
Merged
Merged
Conversation
Pillar-15/16/17 are placeholders that run no probe, and they report passed = true. A gate that reads `passed` therefore counted three pillars that measured nothing as certified. PillarReport gains `deferred: bool` and `certified()` (passed && !deferred); print() shows DEFERRED. `deferred_pillars_are_not_certified` pins 12-14 certified, 15-17 deferred. Cascade::query's Stroke 1 drops a candidate whose scaled prefix estimate exceeds threshold + 3 sigma, with no exact fallback, so a prefix-heavy hit within threshold is lost. That is the design of a statistical cascade, so the behaviour stays; the doc now states recall is not guaranteed and `stroke1_drops_a_prefix_heavy_true_hit` pins it. Also fixes the SplitMix64::new doctest, which failed under deny(warnings) on an unused `mut`. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (18)
✨ Finishing Touches📝 Generate docstrings
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
AdaWorldAPI
marked this pull request as ready for review
October 8, 2026 22:40
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two behaviours flagged by the lance-graph Mexican-hat probe (board entry
2026-10-08-mexhat-bucket-cascade-probe.md).Deferred pillars passed as certified
Pillar-15, -16 and -17 are placeholders. They run no probe, yet they report
passed = true. Any gate that readspassedtherefore counted three pillars that had measured nothing.PillarReportgainsdeferred: bool, set only on those three pillars.certified(), defined aspassed && !deferred. Gates should use this.print()now showsDEFERREDinstead ofPASSfor them.passedkeeps its existing meaning, so existing callers behave the same.PillarReportmust adddeferred: false. All 18 in-tree literals are updated.deferred_pillars_are_not_certifiedpins the split: pillars 12–14 are certified, 15–17 are deferred, anddeferred == (n_paths == 0 && n_hops == 0)on every report.Cascade Stroke 1 recall
Cascade::query's Stroke 1 drops any candidate whose scaled prefix estimate exceedsthreshold + 3σ. Nothing falls back to an exact check, so a hit within the threshold is lost when its differing bits sit in the prefix. That is how a statistical cascade is designed, so the behaviour is unchanged.stroke1_drops_a_prefix_heavy_true_hitpins the behaviour with 128 candidates, all at distance 400 against a threshold of 600:Also
The
SplitMix64::newdoctest failed underdeny(warnings)because of an unusedmut. Fixed.Verification (debug 0)
cargo test -p ndarray --features pillar --release --lib -- pillar cascade: 200 passed.cargo clippy --features pillar --lib -- -D warningsis clean, in both the dev and test profiles.cargo fmtis clean.certified()returningpassed;d <= threshold.Not fixed (pre-existing, unrelated): clippy errors in
tests/splat3d_correctness.rsunder--tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01EFw2WdKr1oxvaKCJC2ua2R
Generated by Claude Code