Repository navigation
Move VCRuntime from DLLs folder to Main - #64
Merged
Merged
Conversation
Remove vcruntime from the main folder, and remove vcruntime from the DLLs subfolder. I tried using the existing apparatus, but matching a substring from the exlusion list to the src string does not work as expected, possibly because of the difference in directories, so I have flipped the substring matching to look for vcruntime within the src. It doesn't look as nice, but it produces the correct result.
|
LGTM |
rickprice
self-requested a review
September 6, 2024 15:57
rickprice
approved these changes
Sep 6, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove vcruntime from the main folder, and remove vcruntime from the DLLs subfolder. I tried using the existing apparatus, but matching a substring from the exlusion list to the src string does not work as expected, possibly because of the difference in directories, so I have flipped the substring matching to look for vcruntime within the src. It doesn't look as nice, but it produces the correct result.