Skip to content

bug/2424 fix 8.2.0 regression in cdp that prevents asset-message from being found - #2425

Merged
JoernBerkefeld merged 1 commit into
developfrom
bug/2424-cdp-no-longer-finds-asset-message
Nov 17, 2025
Merged

JoernBerkefeld merged 1 commit into
developfrom
bug/2424-cdp-no-longer-finds-asset-message

Conversation

@JoernBerkefeld

@JoernBerkefeld JoernBerkefeld commented Nov 17, 2025 •

Copy link
Copy Markdown
Contributor

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 8.2.1 milestone Nov 17, 2025
@JoernBerkefeld JoernBerkefeld self-assigned this Nov 17, 2025
@github-actions github-actions Bot added the bug Something isn't working label Nov 17, 2025
@JoernBerkefeld JoernBerkefeld linked an issue Nov 17, 2025 that may be closed by this pull request
1 of 2 tasks
@github-actions

Copy link
Copy Markdown

Coverage Report

Commit:0ecca56
Base: develop@405c1a8

Type Base This PR
Total Statements Coverage  70.77%  70.76%  (-0.01%)
Total Branches Coverage  70.75%  70.75%  (+0%)
Total Functions Coverage  83.42%  83.42%  (+0%)
Total Lines Coverage  70.77%  70.76%  (-0.01%)
Details (changed files):
File Statements Branches Functions Lines
lib/util/devops.js  13.8%  100%  20%  13.8%

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a regression introduced in version 8.2.0 that prevented asset-message files from being properly identified in CDP (Create Delta Package) operations. The issue occurred when processing asset files that have a nested folder structure with a /blocks/ subdirectory.

  • Updated external key extraction logic for asset types with complex folder structures
  • Added fallback logic to extract keys from folder names when filename-based extraction fails

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
lib/util/devops.js Fixed externalKey extraction for asset-message (and similar asset types) by adding a fallback that reads the key from the folder name (index [5]) when the initial filename-based extraction returns an empty string due to assets with /blocks/ subdirectories
@types/lib/util/devops.d.ts.map Auto-generated TypeScript source map updated to reflect the changes in the JavaScript source file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JoernBerkefeld
JoernBerkefeld merged commit 26f1482 into develop Nov 17, 2025
17 checks passed
@JoernBerkefeld
JoernBerkefeld deleted the bug/2424-cdp-no-longer-finds-asset-message branch November 17, 2025 16:23
@github-actions github-actions Bot mentioned this pull request Nov 17, 2025
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working c/asset COMPONENT e/DevOps EPIC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] cdp no longer finds asset-message

2 participants