Repository navigation
код для гонки в 24 часа. - #1
Open
ARomanov23 wants to merge 1 commit into
Open
ARomanov23 wants to merge 1 commit into
ARomanov23 wants to merge 1 commit into
Conversation
Comment on lines
+3
to
+4
| String name; | ||
| int speed; |
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации извне. Тогда можно будет удалить геттеры
| } No newline at end of file | ||
|
|
||
| public static String carName() { | ||
| while (true) { |
There was a problem hiding this comment.
Не рекомендую писать бесконечные циклы через while (true) - лучше всегда явно прописывать условие выхода из цикла, чтобы уменьшить вероятность ошибиться и повысить читабельность кода
| } | ||
| } No newline at end of file | ||
|
|
||
| public static String carName() { |
There was a problem hiding this comment.
Названия функций лучше начинать с глаголов, так как функции - это действия
| if (scanner.hasNextInt()) { | ||
| int speed = scanner.nextInt(); | ||
| scanner.nextLine(); | ||
| if (speed >= 0 && speed <= 250) { |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Простое консольное приложение, которое вычисляет, какая машина станет победителем гонки.