Skip to content

Commit 120799b

Browse files
matthewdfullermatthewdfuller
committed
fixes for regions
1 parent 807462c commit 120799b

4 files changed

Lines changed: 13 additions & 11 deletions

File tree

‎helpers/aws/regions_china.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ module.exports = {
1919
cloudtrail: regions,
2020
cloudwatchlogs: regions,
2121
cloudformation: regions,
22+
comprehend: [],
2223
configservice: regions,
2324
dms: regions,
2425
dynamodb: regions,

‎helpers/aws/regions_gov.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ module.exports = {
1919
cloudtrail: regions,
2020
cloudwatchlogs: regions,
2121
cloudformation: regions,
22+
comprehend: ['us-gov-west-1'],
2223
configservice: regions,
2324
dms: regions,
2425
dynamodb: regions,

‎plugins/aws/autoscaling/asgActiveNotifications.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var helpers = require('../../../helpers/aws');
33

44
module.exports = {
55
title: 'Auto Scaling Notifications Active',
6-
category: 'Auto Scaling',
6+
category: 'AutoScaling',
77
description: 'Ensures auto scaling groups have notifications active.',
88
more_info: 'Notifications can be sent to an SNS endpoint when scaling actions occur, which should be set to ensure all scaling activity is recorded.',
99
link: 'https://docs.aws.amazon.com/autoscaling/ec2/userguide/ASGettingNotifications.html',

‎plugins/aws/autoscaling/asgMissingELB.js‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ var async = require('async');
22
var helpers = require('../../../helpers/aws');
33

44
module.exports = {
5-
title: 'AutoScaling Group Missing ELB',
5+
title: 'Auto Scaling Group Missing ELB',
66
category: 'AutoScaling',
7-
description: 'Ensures all AutoScaling groups are referencing active load balancers.',
8-
more_info: 'Each AutoScaling group with a load balancer configured should reference an active ELB.',
7+
description: 'Ensures all Auto Scaling groups are referencing active load balancers.',
8+
more_info: 'Each Auto Scaling group with a load balancer configured should reference an active ELB.',
99
link: 'https://docs.aws.amazon.com/autoscaling/ec2/userguide/attach-load-balancer-asg.html',
10-
recommended_action: 'Ensure that the AutoScaling group load balancer has not been deleted. If so, remove it from the ASG.',
10+
recommended_action: 'Ensure that the Auto Scaling group load balancer has not been deleted. If so, remove it from the ASG.',
1111
apis: ['AutoScaling:describeAutoScalingGroups', 'ELB:describeLoadBalancers', 'ELBv2:describeLoadBalancers'],
1212

1313
run: function(cache, settings, callback) {
@@ -29,7 +29,7 @@ module.exports = {
2929
if (!autoScalingGroups || !elasticLoadBalancers || !elasticLoadBalancersV2) return rcb();
3030

3131
if (autoScalingGroups.err || !autoScalingGroups.data) {
32-
helpers.addResult(results, 3, 'Unable to query for AutoScaling groups: ' + helpers.addError(autoScalingGroups), region);
32+
helpers.addResult(results, 3, 'Unable to query for Auto Scaling groups: ' + helpers.addError(autoScalingGroups), region);
3333
return rcb();
3434
}
3535

@@ -44,7 +44,7 @@ module.exports = {
4444
}
4545

4646
if (!autoScalingGroups.data.length) {
47-
helpers.addResult(results, 0, 'No AutoScaling group found', region);
47+
helpers.addResult(results, 0, 'No Auto Scaling group found', region);
4848
return rcb();
4949
}
5050

@@ -77,22 +77,22 @@ module.exports = {
7777

7878
if (inactiveElbs.length){
7979
helpers.addResult(results, 2,
80-
'AutoScaling group utilizes these inactive load balancers: '+ inactiveElbs.join(', '),
80+
'Auto Scaling group utilizes these inactive load balancers: '+ inactiveElbs.join(', '),
8181
region, resource);
8282
} else {
8383
helpers.addResult(results, 0,
84-
'AutoScaling group: ' + asg.AutoScalingGroupName + ' utilizes active load balancers',
84+
'Auto Scaling group: ' + asg.AutoScalingGroupName + ' utilizes active load balancers',
8585
region, resource);
8686
}
8787
}
8888
else {
8989
helpers.addResult(results, 2,
90-
'AutoScaling group does not have any Load Balancer associated', region, resource);
90+
'Auto Scaling group does not have any Load Balancer associated', region, resource);
9191
}
9292
}
9393
else {
9494
helpers.addResult(results, 0,
95-
'AutoScaling group does not utilize a load balancer', region, resource);
95+
'Auto Scaling group does not utilize a load balancer', region, resource);
9696
}
9797

9898
});

0 commit comments

Comments
 (0)