Repository navigation
Conversation
Charmandik
reviewed
Jan 6, 2024
Charmandik
left a comment
Charmandik
left a comment
There was a problem hiding this comment.
Отличное именование функций, приятно читать код, продолжай в том же духе!
| @@ -0,0 +1,16 @@ | |||
| public class Format { | |||
| public static String getEnding(int n) { | |||
There was a problem hiding this comment.
старайся не использовать static. Это сильно упрощает использование, но из-за этого функция и сам класс начинают занимать память, которая никак не очищается, в дальнейшем это приведет к ошибкам
| @@ -0,0 +1,16 @@ | |||
| public class Format { | |||
| public static String getEnding(int n) { | |||
| if (11 <= n % 100 && n % 100 <= 14) { | |||
There was a problem hiding this comment.
для ситуаций когда есть более 2-3 условий, лучше использовать оператор switch-case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.