Repository navigation
df - #1
Open
111Kamil111 wants to merge 1 commit into
Open
df#1111Kamil111 wants to merge 1 commit into
111Kamil111 wants to merge 1 commit into
Conversation
ArturNurtdinov
left a comment
ArturNurtdinov
left a comment
There was a problem hiding this comment.
Привет, на будущее - на проверку необходимо присылать ссылку на PR, а не ссылку на проект, в данном случае ссылка выглядела бы так - https://github.com/111Kamil111/Java-Module-Project-YP/pull/1
Comment on lines
+21
to
+23
| int minSpeed = 0; | ||
| int maxSpeed = 250; | ||
| if (speed > minSpeed && speed <= maxSpeed) { |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
Comment on lines
+39
to
+40
| String name; | ||
| int speed; |
There was a problem hiding this comment.
Поля лучше пометить final, тем самым исключив возможность их модификации извне
Comment on lines
+50
to
+51
| String leader = ""; | ||
| int distance = 0; |
There was a problem hiding this comment.
Эти два поля лучше пометить private, чтобы инкапсулировать логику определения победителя, а для получения имени победителя - написать отдельную функцию-геттер
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.