Add basic support for tag objects#375
Merged
Merged
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
KostyaSha
reviewed
Sep 2, 2017
| * @return the annotated tag object | ||
| */ | ||
| public GHTagObject getTagObject(String sha) throws IOException { | ||
| return root.retrieve().to(getApiTailUrl("git/tags/" + sha), GHTagObject.class).wrap(this); |
Contributor
Author
There was a problem hiding this comment.
Nope it's the tagged and the tag date and the sha of the tagged commit.
For an annotated tag object the tag ref points to a tag object that points to the commit
For a lightweight tag, the tag ref just points to the commit.
jglick
approved these changes
Sep 8, 2017
Contributor
jglick
left a comment
jglick
left a comment
There was a problem hiding this comment.
Seems OK from a quick perusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@reviewbybees