gh-149740: Remove redundant self.empty() check in asyncio.Queue.get()#149741
Open
deadlovelll wants to merge 1 commit into
Open
gh-149740: Remove redundant self.empty() check in asyncio.Queue.get()#149741deadlovelll wants to merge 1 commit into
deadlovelll wants to merge 1 commit into
Conversation
deadlovelll
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
I don't think it's correct. See the issue. |
Member
|
Looking at the other parts of the code, I think it would make indeed more sense to consistently raise on shutdown whether the queue is empty or not. So it is not dead code but it rathet looks like a bug to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug description:
In
Lib/asyncio/queues.py,Queue.get()contains a redundant call toself.empty()inside its waiting loop:self.empty() is guaranteed to be true by the enclosing
while self.empty()the loop body cannot execute otherwise. This check is a dead code.Proposed fix:
Drop the redundant
and self.empty():This PR is cleanup only, no behavior change